chore: minor fix in identifying user #302
Conversation
| } | ||
| CustomerIO.shared.identify(userId: userId, traits: traits) |
There was a problem hiding this comment.
Wouldn't this fail if traits are being attached to anonymous profile? Or do you plan to expose separate method for anonymous case?
There was a problem hiding this comment.
Do you mean if traits is nil ?
There was a problem hiding this comment.
No. I mean, when profile is anonymous i.e. userId is nil. But customer wants to attach traits to anonymous profile. Similar to this method in iOS.
There was a problem hiding this comment.
Ah, you’re right. This doesn’t meet the anonymous profile criteria. Iwilll go ahead and update it.
There was a problem hiding this comment.
Rehan, I just realized that user identification is covered under a separate ticket, which will also address anonymous profiles.
I think it’s best to leave this change for that ticket to avoid scope creep. I understand that this condition doesn’t resolve the anonymous criteria, but I suggest handling it in the upcoming ticket.
Though this current change is also a scope creep but I wanted to do it to help testing the package better and as quick as we can.
I am dropping a note in the ticket so that this fix is not overlooked. Does that make sense?
There was a problem hiding this comment.
Makes sense, since the ticket will make any necessary changes required to handle the case for anonymous profile, I'm good with it 👍🏻
Regarding the conversation on the other PR: I updated the code but forgot to push it to the same PR.